fix: remove unsafe exec() in person.cpp#366
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
basic_content/this/person.cpp.Vulnerability
V-001basic_content/this/person.cpp:10Description: The person.cpp constructor uses strcpy(name, n) to copy a caller-supplied string into a fixed-size char array without any bounds checking. If the caller passes a string longer than the destination buffer, the excess bytes overwrite adjacent stack or heap memory, enabling arbitrary code execution via return-address or function-pointer overwrite. The sig_examp.cpp files use strcpy with hardcoded strings (currently safe) but establish an unsafe coding pattern that is likely to be replicated with variable-length input.
Changes
basic_content/this/person.cppVerification
Automated security fix by OrbisAI Security