Skip to content

Updated the advanced method signature#15

Merged
Cordavi merged 2 commits intomainfrom
update/scheduler-stride
Oct 7, 2024
Merged

Updated the advanced method signature#15
Cordavi merged 2 commits intomainfrom
update/scheduler-stride

Conversation

@SPRSLEPR
Copy link
Contributor

@SPRSLEPR SPRSLEPR commented Oct 1, 2024

What it Does

  • Updated the method signature of the advance method.

How I Tested

  • Compiled the app made sure it build.

Notes

  • I decided to change the existing method signature because I didn't want to create any breaking change form creating two overloaded methods.

Signed-off-by: Ashli Rankin <ashlirankin18@gmail.com>
@SPRSLEPR SPRSLEPR requested a review from Pearapps October 1, 2024 21:18
Copy link
Contributor

@Pearapps Pearapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make sure the tests run before merging, but otherwise Lgtm

@Cordavi Cordavi merged commit 0d799e4 into main Oct 7, 2024
@Cordavi Cordavi deleted the update/scheduler-stride branch October 7, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants