Shared state composable ViewStore example#13
Conversation
|
Updated a bunch of stuff here.... I think we should be better now |
mliberatore
left a comment
There was a problem hiding this comment.
Code looks great. Most of these comments are tiny suggestions or simple docs-related stuff. One general piece of feedback I have is about the contents of the docs similar to the following:
/// State of the banner data store
let bannerState: BannerDataStore.State
/// Determines if the update view should be shown
let showUpdateView: BoolThese docs mostly reword the property name without additional context added. I know in some cases, there really isn’t much that could be added to further explain what a symbol’s name already self-documents (like Banner’s title at the top of the diff), and that makes the task of adding documentation to adhere to guidelines pretty tedious. But in some cases, particularly like showUpdateView, I think we could be more specific, answering questions like "what is an update view"? For example: Determines whether to show a view that allows the user to enter new text for the banner.
Example/Photos/With Stores/Banner Feature/MockBannerNetworkStateController.swift
Outdated
Show resolved
Hide resolved
Example/Photos/With Stores/Banner Feature/View Level/BannerUpdateView.swift
Outdated
Show resolved
Hide resolved
Example/Photos/With Stores/Banner Feature/View Level/BannerUpdateViewStore.swift
Outdated
Show resolved
Hide resolved
Example/Photos/With Stores/Banner Feature/View Level/BannerUpdateViewStore.swift
Outdated
Show resolved
Hide resolved
…teController.swift Co-authored-by: Michael Liberatore <mi@chael.co>
…ateViewStore.swift Co-authored-by: Michael Liberatore <mi@chael.co>
Co-authored-by: Michael Liberatore <mi@chael.co>
|
Did another pass on this, this morning! |
I went through and tried to beef up some of the docs, even if only a little. I am struggling with some of them to add additional context |
mliberatore
left a comment
There was a problem hiding this comment.
Looks great 🙌. One tiny grammar correction, then feel free to merge it with no further review.
Example/Photos/With Stores/Banner Feature/MockBannerNetworkStateController.swift
Outdated
Show resolved
Hide resolved
…teController.swift Co-authored-by: Michael Liberatore <mi@chael.co>
|
Thank you @mliberatore ! Appreciate your reviews and patience with this! |
|
🎉 |
Provides a simple demonstration of the ability to compose
Stores.