Skip to content

ARROW-1976: [Python] PR Feedback for Fix Pandas data SerDe with Unicode column names in Python 2.7 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
merged 3 commits into
base: fix-unicode-serde-in-py27
Choose a base branch
from
Feb 1, 2018
Open

ARROW-1976: [Python] PR Feedback for Fix Pandas data SerDe with Unicode column names in Python 2.7 #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1d65c1
Not using str with frombytes to ensure Python3 tests pass.
simnyatsanga Feb 1, 2018
cefc767
Removing additional instances of using frombytes with str.
simnyatsanga Feb 1, 2018
15a2366
Removing additional instances of using frombytes with str.
simnyatsanga Feb 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python/pyarrow/pandas_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def get_column_metadata(column, name, arrow_type, field_name):
)

if not isinstance(field_name, six.string_types):
field_name = frombytes(str(field_name))
field_name = frombytes(field_name)

return {
'name': name,
Expand Down Expand Up @@ -319,7 +319,7 @@ def dataframe_to_arrays(df, schema, preserve_index, nthreads=1):
if not isinstance(name, six.string_types):
name = _column_name_to_strings(name)
if name is not None:
name = frombytes(str(name))
name = frombytes(name)

if schema is not None:
field = schema.field_by_name(name)
Expand Down Expand Up @@ -550,7 +550,7 @@ def table_to_blockmanager(options, table, memory_pool, nthreads=1,
for c in columns:
column_name = c['name']
if not isinstance(column_name, six.text_type):
column_name = frombytes(str(column_name))
column_name = frombytes(column_name)

columns_name_dict[c.get('field_name', column_name)] = c['name']

Expand Down