Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libsharp #22

Open
zonca opened this issue Jun 5, 2019 · 6 comments
Open

Update libsharp #22

zonca opened this issue Jun 5, 2019 · 6 comments

Comments

@zonca
Copy link
Member

zonca commented Jun 5, 2019

is it possible to update this repository to have the last version of libsharp?

@mreineck
Copy link
Collaborator

mreineck commented Jun 6, 2019

I'm planning to do this, but I don't know yet how exactly it is going to happen.
The latest version has a slightly changed interface and some functionality is no longer present, so I think this requires a major version bump, or maybe even a change in name. I'm not sure yet whether I should open a new project for this or just put it into a new branch of the existing repository. Comments are welcome!

Development of libsharp has shifted to https://gitlab.mpcdf.mpg.de/mtr/libsharp, but I plan to sync the Github repository when releases take place.

@zonca
Copy link
Member Author

zonca commented Jun 6, 2019

I think the best would be to port the Python interface to gitlab and then close this repository (archive it) and just have 1 repo.

@mreineck
Copy link
Collaborator

mreineck commented Jun 7, 2019

That would be convenient, but there is much work by @dagss in the current version which is used by many people, and which absolutely needs to be kept visible.
I will provide a Python interface for the new version.

@mreineck
Copy link
Collaborator

mreineck commented Jun 7, 2019

I possible, I'd like to switch from cython to pybind11 for the Python interface.
Would the interface that is currently part of pyHealpix (https://gitlab.mpcdf.mpg.de/ift/pyHealpix) be OK? Then I'd just copy the relevant parts over...

@zonca
Copy link
Member Author

zonca commented Jun 7, 2019 via email

@mreineck
Copy link
Collaborator

There is now a first version of a Python interface at
https://gitlab.mpcdf.mpg.de/mtr/libsharp/tree/add_python

At the moment, you still have to set sharp_libpath by hand at the top of setup.py, if the sharp library is not in the system's search path. I'm not sure how this is done properly.

Also, the whole "darwin" section is probably completely broken...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants