Skip to content

developer documentation #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Conversation

Any97Cris
Copy link
Contributor

No description provided.

Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
@Any97Cris Any97Cris self-assigned this Jun 9, 2025
@vitormattos vitormattos changed the title create guite contribution create git contribution Jun 10, 2025
@vitormattos vitormattos changed the title create git contribution create guide contribution Jun 10, 2025
Copy link
Member

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is Contribution guide

Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
@Any97Cris Any97Cris force-pushed the feat/contribution-pr-commit branch from fd2fd47 to 36cbdf2 Compare June 10, 2025 18:28
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
@Any97Cris Any97Cris requested a review from vitormattos June 10, 2025 20:37
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
@Any97Cris Any97Cris requested a review from vitormattos June 11, 2025 17:57
@@ -0,0 +1,200 @@
Contributing Guide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking now, sounds as duplicated of https://github.com/LibreSign/libresign/blob/main/CONTRIBUTING.md.

The developer manual is a contributing guide with more details of all steps. The CONTRIBUTING file at LibreSign repository could be reduced and I think that would be best to create here, at developer manual, the follow content that could be splitted into the files named with the root elements of this tree:

  • Translation
    • How translate LibreSign at Transifex
    • Add and/or change texts at LibreSign code using the L10N libraries. Would be good point to Nextcloud developer documentation at this point.
    • A quick instructions about how the translated text will go back to LibreSign repository
    • A warning talking that the l10n can't be changed
  • Setup environment
    Will be necessary move part of https://github.com/LibreSign/libresign/blob/main/CONTRIBUTING.md to here and add a comment ato CONTRIBUTING.md pointing to here about the environment
    • Prerequirements
      • PHP version
        • Why use the minimum PHP version. We can't send a code using features that only works at newest version of PHP. LibreSign need to be compatible with minimum PHP version accepted by relative Nextcloud server version
        • how to set the PHP version at LibreCode environment
      • Node version and where is possible to check the place that have this information (package.json)
      • Other not mandatory dependencies but important to have and explain that the LibreCode Nextcloud docker environment already have the follow dependencies.
        • poppler-utils
        • locale charmap as UTF-8 at operational system
  • Branch policies
    • Expose about main and stable branches
    • Explain that the development is at main branch of LibreSign
    • Creating branch and suggestion about branch nomenclature
  • Commits
    • Conventional commits
      • Comments about conventional commits exposing a bit why we use this
      • possible issues about Conventional commits
    • DCO.
      • Expose why we use DCO.
      • Fixing possible issues about DCO
  • pull request
    • How to open
      • Instructions about destination branch
      • Possible issues about conventional commits and DCO and point to this documentation at the point that explain about this

I know that have a lot of contents. Maybe this could be made into separated commits and pull requests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to talk about bring the documentation inside libresign repository to here. Let me change the informations and send another commit.

@Any97Cris Any97Cris marked this pull request as ready for review June 16, 2025 17:07
@Any97Cris Any97Cris changed the title create guide contribution create contribution guide Jun 16, 2025
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
@Any97Cris Any97Cris requested a review from vitormattos June 18, 2025 19:15
--------

Welcome
^^^^^^^^^^^^^^^^^^^^^^^^^^
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to have the same char quantity of header.

@@ -0,0 +1,239 @@
Contributing to LibreSign
==================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to have the same char quantity of header.


Before you get started, we encourage you to read our code of conduct, which describes our community norms:

* 1. `Our code of conduct < />`__, which explicitly stipulates that everyone must be gracious, respectful, and professional. This also documents our conflict resolution policy and encourages people to ask questions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, verify and tell if this PR is ok. I bring all conduct code to #52

If you would prefer to write code, you may wish to start with our list of good first issues for LibreSign. See the respective sections below for further instructions.


Front and backend development environment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Front and backend development environment
Development environment

Front and backend development environment
+++++++++++++++++++++++++++++++++++++++++

This project depends on the NextCloud project, so to start writing code, you will need to set it up. We recommend using Docker for this, but feel free to use another method if you prefer. We suggest these two setups:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This project depends on the NextCloud project, so to start writing code, you will need to set it up. We recommend using Docker for this, but feel free to use another method if you prefer. We suggest these two setups:
This project depends on the Nextcloud project, so to start writing code, you will need to set it up. We recommend using Docker for this, but feel free to use another method if you prefer. We suggest these two setups:

api
contributing-guide
Copy link
Member

@vitormattos vitormattos Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a contribuding guide. The contributing guide is this:

https://github.com/LibreSign/libresign/blob/main/CONTRIBUTING.md

And we will need to move parts of CONTRIBUTING to documentation site to don't have duplicated content and also will be necessary have links from CONTRIBUTING to this documentation site.

Would be good to split this file into dedicated files to don't create the entire documentation into a single file.

I suggested here a tree of contents:

#49 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, verify and tell if this PR is ok. I bring all conduct code to #52

@Any97Cris Any97Cris requested a review from vitormattos June 20, 2025 12:15
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
@Any97Cris
Copy link
Contributor Author

Any97Cris commented Jun 20, 2025

Ok, I will follow the steps(#49 (comment)) in this commit(b0d8af3).

Not ready yet

Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
@Any97Cris Any97Cris changed the title create contribution guide developer documentation Jun 26, 2025
@Any97Cris Any97Cris added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jun 26, 2025
@Any97Cris Any97Cris marked this pull request as draft June 26, 2025 18:58
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants