fix(cli): Gracefully handle browser-only authentication#140
Open
kylemurray2 wants to merge 1 commit intoLibreScore:masterfrom
Open
fix(cli): Gracefully handle browser-only authentication#140kylemurray2 wants to merge 1 commit intoLibreScore:masterfrom
kylemurray2 wants to merge 1 commit intoLibreScore:masterfrom
Conversation
The CLI was crashing with a `ReferenceError: document is not defined` because it was trying to execute browser-specific code for authentication. This change introduces an environment check using `detect-node` to prevent browser-only code from running in the Node.js environment. - In `src/file.ts`, the `getApiAuthNetwork` function now throws an error when called in Node.js, as it relies on browser APIs. - The `getSuffix` function is also made safe for Node.js execution. - In `src/cli.ts`, a `try...catch` block is added to the download logic to gracefully handle the error thrown by `getApiAuthNetwork` and other potential download errors. This prevents the application from crashing and provides a user-friendly error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI was crashing with a
ReferenceError: document is not definedbecause it was trying to execute browser-specific code for authentication.This change introduces an environment check using
detect-nodeto prevent browser-only code from running in the Node.js environment.src/file.ts, thegetApiAuthNetworkfunction now throws an error when called in Node.js, as it relies on browser APIs.getSuffixfunction is also made safe for Node.js execution.src/cli.ts, atry...catchblock is added to the download logic to gracefully handle the error thrown bygetApiAuthNetworkand other potential download errors. This prevents the application from crashing and provides a user-friendly error message.