-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce Face Classification #1418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add new field to soft delete faces - add new classification and clustering fields to differentiate between matching algos - remove unnecessary fields to differentiate between inferred or not - remove unknown person and replace it with a simple none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reintroduces classification alongside the existing clustering functionality, ensuring both methods work together seamlessly. It also implements a soft delete feature, improving data handling and user control. Additionally, the refactor enhances clarity in differentiating user input from algorithmic input, addressing ambiguities in data origins.
Key Changes
Classification Reintroduction:
Adds classification without disrupting the current clustering setup.
Classification improves accuracy for larger datasets where most persons are already known.
Soft Delete Feature:
Allows entities to be "soft deleted," enabling recovery and improving data integrity without permanent deletion.
Input Differentiation:
Replaces the binary inferred field with three distinct relationships to persons. These relationships clarify whether the input was matched by a user or one of two algorithms.
Enables tracking of which algorithm matched an entity, providing transparency and control over the results.
Addressed Issues
This PR resolves multiple issues related to input ambiguity and clustering limitations, including: #978 #848 #1409 #879
#600 #598 #501
Rationale Behind Clustering and Classification
Clustering was retained due to its effectiveness in cold start scenarios where no user data exists. It helps match faces even when no persons have been added to the system.
However, common clustering problems include:
Classification addresses these limitations by improving accuracy in cases where all persons are already known, ensuring better results for large datasets.
Additional Improvements