[le11] fix mpd build #6016
Merged
[le11] fix mpd build #6016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes following build error: ./toolchain/armv7a-libreelec-linux-gnueabihf/sysroot/usr/lib/ libopenmpt.a(libopenmpt_la-Load_xm.o):Load_xm.cpp:function OpenMPT::ReadSampleData(OpenMPT::ModSample&, OpenMPT::SampleIO, OpenMPT::detail::FileReader<OpenMPT::FileReaderTraitsStdStream>&, bool&): error: undefined reference to 'ov_open_callbacks'
Closed
scripts/build mpd was not including libopenmpt, this was not the case when the addon script was run - thus getting different results. Include libopenmpt here so as to ensure that standalone build and jenkins mpt build are the same.
release notes: - https://lib.openmpt.org/libopenmpt/2021/12/05/security-updates-0.5.14-0.4.26-0.3.35/ - https://lib.openmpt.org/libopenmpt/2021/12/23/security-update-0.5.15-releases-0.4.27-0.3.36/ update 0.5.13 (2021-11-14) to 0.5.15 (2021-12-23) --- 0.5.15 --- [Sec] Possible out-of-bounds read of stack-allocated array in malformed AMS files. (r16243) [Bug] Fixed various undefined behaviour found with ubsan. IT: Even after libopenmpt 0.5.14 the filter reset logic was still not 100% identical to Impulse Tracker: A note triggered on tick 0 of a row with a Pattern Delay effect still caused the filter to be reset on repetitions of that row even though the note wasn’t retriggered. MOD: Loosened VBlank timing heuristics so that the original copy of Guitar Slinger from Dizzy Tunes II plays correctly. mpg123: Update to v1.29.3 (2021-12-11). --- 0.5.14 --- [Sec] Possible out-of-bounds read in Chorus plugin with NaN plugin parameters. Most implementations of the “fast math” compiler optimizations will prevent this crash but it is not guaranteed. (r16096) [Bug] Fixed undefined behaviour with custom tunings found with ubsan. OPL: Improved channel allocation strategy when there are lots of faded-out notes. MOD: Digital Tracker MODs have four unknown bytes right after the magic bytes which seem to be ignored even by Digital Tracker itself. Just skip over them. The logic when to turn off the resonant filter was broken in some edge cases since libopenmpt 0.5.1. IMF: Implemented XE1-XE3 commands, which disable individual envelopes. Command Nxy (cutoff slide + resonance) is now also partially supported (only resonance for now). IMF: Filter envelopes were upside down. MTM: Omitting pattern loading through the load.skip_patterns ctl caused sample data to be corrupted. S3M: Ignore O00 commands in files created with Scream Tracker 3.00 and 3.01, as this command only gained effect memory in version 3.03. STM: Use S3M-like sample swap behaviour. XM: Disable arpeggio quirk for XMs made with Skale Tracker. Fixes KAPTENFL.XM. miniz: Update to v2.2.0 (2021-06-27). minimp3: Update to commit 50d2aaf360a53653b718fead8e258d654c3a7e41 (2021-11-27).
Merged
CvH
approved these changes
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt in fixing build of mpd.
reproducibility was the first issue
libopenmptas a dependency ofmpdSecond issue was the
libvorbisfileis a required library oflibopenmpt