add kernel options for hid devices

[lrusak]

This is long overdue. These options should be unified across all devices.

I've simply made this list from what is enabled on my fedora workstation and I'm open to changes if anyone has any recommendations (I assume ubuntu would be similar).

[HiassofT]

Please don't just take the list of what's enabled on your (probably x86) Fedora box but take the time to check the entries for what's really relevant for ALL libreelec devices.

I don't think any ARM box will get in contact with the Apple IR receiver or the Asus notebook keyboard attached via I2C - I stopped looking at the remaining options at this point

config HID_APPLEIR
        tristate "Apple infrared receiver"
        depends on (USB_HID)
        help
        Support for Apple infrared remote control. All the Apple computers from
          2005 onwards include such a port, except the unibody Macbook (2009),
          and Mac Pros. This receiver is also used in the Apple TV set-top box
          prior to the 2010 model.
...
config HID_ASUS
        tristate "Asus"
        depends on USB_HID
        depends on LEDS_CLASS
        depends on ASUS_WMI || ASUS_WMI=n
        select POWER_SUPPLY
        help
        Support for Asus notebook built-in keyboard and touchpad via i2c, and
        the Asus Republic of Gamers laptop keyboard special keys.

[lrusak]

Please don't just take the list of what's enabled on your (probably x86) Fedora box but take the time to check the entries for what's really relevant for ALL libreelec devices.

I don't think any ARM box will get in contact with the Apple IR receiver or the Asus notebook keyboard attached via I2C - I stopped looking at the remaining options at this point

may I quote myself?

I'm open to changes if anyone has any recommendations (I assume ubuntu would be similar).

Please check your tone and work to give constructive feedback 😃

[HiassofT]

Sorry if this came over the wrong way, but the recommendation you asked us for was as I wrote in my first sentence:

Please don't just take the list of what's enabled on your (probably x86) Fedora box but take the time to check the entries for what's really relevant for ALL libreelec devices.

Also your PR also seems to change a lot of HID devices from y to m (compared to eg what's currently in RPi kernel config) which means they will no longer work during init - which isn't really great if you need that HID device during init (eg rescue/panic mode).

So, please start again from scratch, not taking the config of your Fedora box as a starting point but looking at the config we currently have eg for Generic or RPi.

I'm marking this PR as WIP and with MERGE BLOCKED so it doesn't accidentally get merged

[lrusak]

Sorry if this came over the wrong way, but the recommendation you asked us for was as I wrote in my first sentence:

Please don't just take the list of what's enabled on your (probably x86) Fedora box but take the time to check the entries for what's really relevant for ALL libreelec devices.

Also your PR also seems to change a lot of HID devices from y to m (compared to eg what's currently in RPi kernel config) which means they will no longer work during init - which isn't really great if you need that HID device during init (eg rescue/panic mode).

So, please start again from scratch, not taking the config of your Fedora box as a starting point but looking at the config we currently have eg for Generic or RPi.

I'm marking this PR as WIP and with MERGE BLOCKED so it doesn't accidentally get merged

Then please review to actually provide feedback, not just "please start again from scratch". 😃

If you think I should set all keyboard type devices to y, then say so.
If you think I should set all joystick type devices to m then say so.
If you think a specific config shouldn't be set at all then say so (and comment on that line).

Considering our Generic and RPi configs for HID devices are just an amalgamation of years of leftovers and individual changes, they are not really a great start.

This is always going to be subjective really but that's the point of having a master list for all projects and even then it's never going to be perfect. So I'd rather start somewhere and we can always make changes down the line. That is also the point of having a proper discussion and review. 📈

[HiassofT]

Sure there's lots of cruft in our configs but there are also a lot of options that were deliberately set to y- like keyboard HIDs (eg CONFIG_HID_LOGITECH / CONFIG_HID_LOGITECH_DJ). Or oddball stuff that we seemed is not actually needed in LE - eg CONFIG_HID_NTRIG.

Ignoring all that and just proposing to move everything to your Fedora config (which will have initrd with modules) without any comments why a specific module should be enabled on all LE configs, why a device built into kernel should be changed to a module is not a good start.

Sorry, your PR is in no state for a proper review, I already pointed out several issues and proposed a way to move forward, so the onus here is really on you if you want to get that into LE.

[lrusak]

Sorry, your PR is in no state for a proper review, I already pointed out several issues and proposed a way to move forward, so the onus here is really on you if you want to get that into LE.

Ok I've updated it with my personal opinion. Time for review! 😺

[lrusak]

A year later and no comments, I assume it's g2g?

[HiassofT]

No, it's still the same as after one year the only motivation for changing all those settings was because it's "your personal opinion" - that's not really a solid explanation why you changed each individual option which we can use as a base to review it.

Also this is way too huge to review, back then I started reviewing it but gave up - checking each individual kernel option took too much time.

And, as I already stated, take RPi/Generic config as a base to align the other projects, this is proven to be working and a solid base we can work on,not just personal opinion.

If you want to change something from RPi/Generic config explicitly explain why you changed each setting - this is something we can try to review.