Repository navigation
🧭 fix: Relay Loopback Resolvers Into KVM Guests #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
704e004
🧭 fix: Relay Loopback Resolvers Into KVM Guests
danny-avila 5947524
🧭 fix: Bound the Guest DNS Relay and Relay IPv6 Loopback
danny-avila 96fadf2
🧭 fix: Recognize Every Loopback Resolver Spelling
danny-avila 582be7c
🧭 fix: Parse Nameserver Addresses Before Loopback Detection
danny-avila File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
/etc/resolv.confhasnameserver ::1as its only resolver, this predicate returns no loopback nameserver, and the matching IPv4-only check inencode_resolv_confforwards::1unchanged. Startup therefore succeeds, but the guest sends DNS queries to its own IPv6 loopback where no resolver is listening—the same failure this change fixes for127.x. Detect::1and either provide an IPv6 relay or reject/drop it in favor of a usable resolver.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 5947524. A
::1nameserver now counts as loopback. It gets the same IPv4 listener on the runner address, forwarded withUDP6-SENDTO:[::1]:53/TCP6:[::1]:53, and the guest receives the runner address in its place. Tests cover::1alone and::1after127.0.0.11, where the second loopback entry is dropped.