Repository navigation
馃Ь fix: normalize PTC JSON-string inputs - #199
Conversation
|
@codex review |
8aea450 to
9fd89f3
Compare
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8aea45027e
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9fd89f3 to
e508a24
Compare
|
@codex review |
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e508a248ff
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e508a24 to
dc6b04b
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! 鈩癸笍 About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 馃憤. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
I fixed programmatic tool execution so bridge/runtime input shapes are normalized according to the target tool schema before LangChain validates the call.
PTCToolCall.inputto reflect that bridge callers can provide either object input or serialized JSON text._call; whenexecuteTools()passed a JSON string directly into a tool with az.object(...)schema, validation failed withReceived tool input did not match expected schemabefore the MCP tool or_ptclayer ran.Change Type
Testing
Test Configuration:
/Users/danny/Projects/agents/Users/danny/Projects/clickhouse-ai/services/codeapihttp://localhost:3112/v1danny-avila/fix-ptc-json-string-inputnpm testscriptChecklist