🪢 chore: Consolidate Pricing and Tx Imports After tx.js Module Removal

[danny-avila]

Summary

Resolves broken import references across agent controllers and middleware caused by a rebase on top of the DB consolidation (PR #11830), which removed api/models/tx.js and moved all methods into the unified ~/models export. Includes type safety improvements and test infrastructure cleanup surfaced during the fix.

• Removes ~/models/tx imports from client.js, openai.js, responses.js, and abortMiddleware.js, replacing getMultiplier and getCacheMultiplier references with db.getMultiplier and db.getCacheMultiplier from the unified ~/models object.
• Consolidates abortMiddleware.js to a single const db = require('~/models') import, routing all previously destructured calls (spendTokens, saveMessage, getConvo, bulkInsertTransactions, updateBalance) through db.*.
• Adds bulkInsertTransactions to createTransactionMethods with an early-exit guard and try/catch error logging consistent with surrounding methods, and exposes both it and updateBalance in the method return object.
• Fixes a silent test bug in recordCollectedUsage.spec.js where two sequential jest.mock('~/models', ...) calls caused the second to silently overwrite the first, leaving getMultiplier, getCacheMultiplier, and bulkInsertTransactions unmocked.
• Migrates pricing mocks from the deleted ~/models/tx module into the unified ~/models mock across openai.spec.js, responses.unit.spec.js, abortMiddleware.spec.js, and recordCollectedUsage.spec.js.
• Migrates addAgentResourceFile and removeAgentResourceFiles mocks from the defunct ~/models/Agent module into the unified ~/models mock in process.spec.js.
• Rewires transactions.bulk-parity.spec.ts to source getMultiplier/getCacheMultiplier via createMethods instead of the deleted api/models/tx.js, inlines required helper functions with keep-in-sync JSDoc comments pointing to the canonical test-helpers.ts source, and corrects import ordering.
• Narrows findMatchingPattern's values parameter type from Record<string, unknown> to Record<string, number | Record<string, number>> across tx.ts, methods/index.ts, and test-helpers.ts.
• Tightens TokenConfig's index signature in tokens.ts from [key: string]: unknown to [key: string]: number, removing a long-standing type escape hatch.
• Introduces a TokenType = 'prompt' | 'completion' union in transactions.ts, replacing loose string on tokenType fields in GetMultiplierParams, StandardTxData, and StructuredTxData.
• Corrects ?? 0 cache multiplier fallbacks to ?? promptMultiplier in transaction.spec.ts and transactions.bulk-parity.spec.ts, aligning test cost calculations with production semantics in calculateStructuredTokenValue.

Change Type

• Bug fix (non-breaking change which fixes an issue)

Testing

All affected test suites pass locally. The consolidation is verified by the existing test infrastructure — since the mocks now mirror the production module shape exactly, any future drift between ~/models exports and mock definitions will surface immediately at test time rather than silently at runtime.

Test Configuration:

• cd api && npx jest abortMiddleware — verifies abort path spending and double-spend prevention
• cd api && npx jest recordCollectedUsage — verifies the duplicate-mock fix and dep wiring
• cd api && npx jest openai.spec — verifies pricing mock consolidation
• cd api && npx jest responses.unit — verifies pricing mock consolidation
• cd api && npx jest process.spec — verifies agent file mock consolidation
• cd packages/data-schemas && npx jest transaction.spec — verifies type-narrowing and corrected cost calculations
• cd packages/api && npx jest transactions.bulk-parity — verifies bulk path pricing wired through createMethods

Checklist

• My code adheres to this project's style guidelines
• I have performed a self-review of my own code
• I have commented in any complex areas of my code
• My changes do not introduce new warnings
• I have written tests demonstrating that my changes are effective or that my feature works
• Local unit tests pass with my changes
• Any changes dependent on mine have been merged and published in downstream modules.

[Copilot]

Pull request overview

This PR resolves import issues introduced by a rebase by standardizing token-spend/pricing dependencies to come from the main ~/models export.

Changes:

• Replace ~/models/tx pricing imports with db.getMultiplier/db.getCacheMultiplier from ~/models.
• Route token-spend calls through db.spendTokens/db.spendStructuredTokens where needed.
• Adjust recordCollectedUsage dependency wiring to use the unified db models object.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
api/server/middleware/abortMiddleware.js	Switches spend/pricing deps to db and updates fallback spending call.
api/server/controllers/agents/responses.js	Updates pricing deps passed into recordCollectedUsage to use db.*.
api/server/controllers/agents/openai.js	Updates pricing deps passed into recordCollectedUsage to use db.*.
api/server/controllers/agents/client.js	Updates pricing deps passed into recordCollectedUsage to use db.*.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

~/models is required twice (destructured on line 11 and again as db on line 16). Consolidate to a single import (either use only db.* everywhere, or destructure all needed methods including spendTokens, spendStructuredTokens, getMultiplier, getCacheMultiplier) to avoid inconsistency and simplify downstream Jest mocks.

[Copilot]

Switching pricing to db.getMultiplier/db.getCacheMultiplier means recordCollectedUsage will throw if those functions are missing (e.g., current unit tests mock ~/models without them and mock ~/models/tx instead). Update the tests/mocks to provide these methods on ~/models (or reintroduce a dedicated pricing export) so CI doesn’t break.

Suggested change

	pricing: { getMultiplier: db.getMultiplier, getCacheMultiplier: db.getCacheMultiplier },
	pricing: {
	getMultiplier: db.getMultiplier || (() => 1),
	getCacheMultiplier: db.getCacheMultiplier || (() => 1),
	},

[Copilot]

pricing now references db.getMultiplier/db.getCacheMultiplier. Existing Jest unit tests in this area currently mock ~/models/tx and mock ~/models without these methods, which will make recordCollectedUsage crash when it calls pricing functions. Update the tests/mocks to attach getMultiplier/getCacheMultiplier to the ~/models mock (or provide a stable pricing module to mock).

Suggested change

	pricing: { getMultiplier: db.getMultiplier, getCacheMultiplier: db.getCacheMultiplier },
	pricing: {
	getMultiplier: db.getMultiplier || (() => 1),
	getCacheMultiplier: db.getCacheMultiplier || (() => 1),
	},

[Copilot]

Same as above: pricing now uses db.getMultiplier/db.getCacheMultiplier, so any unit tests that mock ~/models must include these exports (tests currently mock ~/models/tx). Without updating those mocks, recordCollectedUsage will throw when it invokes the pricing functions.

[Copilot]

pricing now pulls getMultiplier/getCacheMultiplier off db. Ensure the ~/models module (and any Jest mocks of it) exports these functions; current tests mock ~/models/tx for pricing and will break because recordCollectedUsage expects callable pricing functions.