Smarty template implementation flaws #333
Description
The template implementation and documentation has several issues. I tried to add a custom template, but got an error indicator when clicking the update button, but no error messsage.
The reason is, that the custom-template file could not be written. The file would be written to the folder lang/de_de by the line:
But the documentation does not mention lang to be writable. Instead it mentions that tpl and tpl_c should be writable and refers to the documention. So i had a look at the Smarty documentation:
The compile dir and cache dir need to be writable
I always thought tpl_c was the cache directory. But in fact it's the compile directory. The cache directory would be cache
But caching is always set to false:
Proposal
- Only two writeable directories
uploadfor user contentrun_datafor code generated files - Make installer check writeability for those folders, and create all nescessary subfolders in
run_data. (tpl_c, logs, etc.) - Write custom tepmplates only to a
run_datasubfolder. - Fix caching
- Error message in front end, when saving custom template fails