Skip to content

ci(release): add the 'id-token' permissions#948

Merged
JohnVillalovos merged 1 commit intodevelopfrom
jlvillal/release_token
Feb 4, 2026
Merged

ci(release): add the 'id-token' permissions#948
JohnVillalovos merged 1 commit intodevelopfrom
jlvillal/release_token

Conversation

@JohnVillalovos
Copy link
Collaborator

This is mentioned in the python-semantic-release documentation

This is mentioned in the python-semantic-release documentation
Copilot AI review requested due to automatic review settings February 4, 2026 22:06
@JohnVillalovos JohnVillalovos enabled auto-merge (rebase) February 4, 2026 22:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds the id-token: write permission to the release workflow, citing python-semantic-release documentation as the rationale.

Changes:

  • Added id-token: write permission to the release job in the GitHub Actions workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


permissions:
contents: write
id-token: write
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id-token: write permission is typically used for PyPI trusted publishing with OIDC tokens, Sigstore signing, or authentication with cloud providers. Based on the workflow steps, none of these features appear to be in use:

  • This is a PHP project (composer.json), not a Python package
  • The workflow only creates GitHub releases and uploads assets
  • No PyPI publishing, Sigstore signing, or cloud authentication is configured

Adding this permission increases the attack surface without apparent benefit. Could you clarify which specific step in this workflow requires the id-token permission? If it's not actively being used, consider removing it to follow the principle of least privilege.

If the documentation recommends this for future features or specific configurations, please verify that those features are actually enabled in your releaserc.toml configuration.

Suggested change
id-token: write

Copilot uses AI. Check for mistakes.

permissions:
contents: write
id-token: write
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release-dry-run.yml workflow (which uses the same python-semantic-release action) does not include the id-token: write permission. For consistency and to maintain the principle of least privilege, both workflows should have the same permissions unless there's a specific reason for the difference. If id-token is needed for release.yml, consider whether it's also needed for release-dry-run.yml, or vice versa.

Copilot uses AI. Check for mistakes.
@JohnVillalovos JohnVillalovos merged commit 9b6b28a into develop Feb 4, 2026
17 checks passed
@JohnVillalovos JohnVillalovos deleted the jlvillal/release_token branch February 4, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant