Recurring blocked times off by one day after the first week

[ikke-t]

Describe the bug**

I try to block a resource reservation only to happen each thursday. It works for the first week, but rest of the weeks it is off by one, being open for reservations at fridays. Apologies the screenshots are from Finnish lang, but that's what I have on my tablet while on road.

To Reproduce**

Steps to reproduce the behavior:

1. Timezone is Europe/Helsinki
2. Calendar week start day is monday (doesn't make difference)
3. Go to block resources
4. Select time range from 0 to 24
5. Select repeat weekly
6. Select all days but thursday

Expected behavior**

Resource calendar should show resource available each thursday, and rest of the days blocked. Instead, only the first thursday is available and all the rest weeks friday is only available day.

Screenshots**

Additional context**

I tried changing the start of the week day for calendar back to sunday. No difference. If I change the time from 0-24 to say 17-24, the first occurance is also day off. So perhaps also some tz miscalculation.

I verified both LB and mariadb TZ are in Helsinki.

Specifications

• LibreBooking version (or SHA if using the develop bproblem: sorry on travel with no access to laptop, but last weeks version from git.

[ikke-t]

Finally got home to laptop. So here are the pictures in english language. This time it again fails differently. I use now the provided docker image, and also tested the librebooking demo environment. The blocking feature is broken, I don't get the blockers work in case I try to restrict the reservations to certain week days.

To create the weekly blocker:

And this is the outcome, not being weekly blocked:

The times are first possible - last one, 0 AM to 11.30 PM. For some reason the time gets too small field in the gui, so the first 1 is dropped.

[ikke-t]

I figured out the error here. My error. The recurring blocker requires end date. I did not realize it is mandatory, and the blocker creation goes through without it. But if it is missing, outcomes are rather random. After setting end date the creation takes a while but eventuallu creates the blocks.

It would be an enhancement to have some indication the end date is mandatory.