Edit weekly series checkboxes problem

[belcirelk]

[x]: This is a bug and not a question.

[x]: I understand that the best way to resolve this issue is to solve it and propose a Pull Request.

Describe the bug**

When editing a weekly series, the days buttons are highlighted but are actually not selected. The result is that reservations that you want to update will be deleted.

To Reproduce**

Steps to reproduce the behavior:

1. Create a weekly series and check Monday, Tuesday, Wednesday, Thurdays and Friday.
2. Save
3. Now click on one of the reservations and all the buttons seems active.
4. However, the checkbox associated to them are not checked.
5. If you save your modifications, most of your series will be deleted except the day of the current reservation you are editing when you select all instences.

Expected behavior**

Screenshots**

Additional context**

Specifications

• LibreBooking version (or SHA if using the develop branch):

[belcirelk]

It looks like this part of js is problematic by adding an active class that is interfering with bootstrap. And the checkboxes are also not checked.

function InitializeRepeatOptions() {
      if (options.repeatType) {
          elements.repeatOptions.val(options.repeatType);
          elements.repeatInterval.val(options.repeatInterval == '' ? 1 : options.repeatInterval);
          ChangeRepeatOptions();

          for (var i = 0; i < options.repeatWeekdays.length; i++) {
              var id = '#' + prefix + 'repeatDay' + options.repeatWeekdays[i];
              if (!$(id).is(':checked')) {
                  //$(id).closest('label').button('toggle');
                  $('label[for="' + id.replace(/#/g, '') + '"]').addClass('active');
              }
          }

          $("#" + prefix + "repeatOnMonthlyDiv :radio[value='" + options.repeatMonthlyType + "']").prop('checked', true);
      }

      elements.repeatOnWeeklyDiv.find('label').click(function (e) {
          NotifyChange();
      });
      elements.repeatOnMonthlyDiv.find('label').click(function (e) {
          NotifyChange();
      });
  }

[belcirelk]

This seems to work, the goal was to remove the active class and make sure the checkboxes are checked on loading:

function InitializeRepeatOptions() {
    if (options.repeatType) {
        elements.repeatOptions.val(options.repeatType);
        elements.repeatInterval.val(options.repeatInterval == '' ? 1 : options.repeatInterval);
        ChangeRepeatOptions();

        
        for (var i = 0; i < options.repeatWeekdays.length; i++) {
            var id = prefix + 'repeatDay' + options.repeatWeekdays[i];
            $('#' + id).prop('checked', true);
        }

        
        $("#" + prefix + "repeatOnMonthlyDiv :radio[value='" + options.repeatMonthlyType + "']").prop('checked', true);
    }
    
        elements.repeatOnWeeklyDiv.find('input[type="checkbox"]').on('change', function() {
        NotifyChange();
    });
    
    elements.repeatOnMonthlyDiv.find('input[type="radio"]').on('change', function() {
        NotifyChange();
    });
}