assign values to argument namespace instead of parser#108
Merged
acdha merged 3 commits intoLibraryOfCongress:masterfrom Sep 17, 2018
Merged
assign values to argument namespace instead of parser#108acdha merged 3 commits intoLibraryOfCongress:masterfrom
acdha merged 3 commits intoLibraryOfCongress:masterfrom
Conversation
Member
|
It looks like most of the changed lines are whitespace-related. Can you run your branch through Black first? |
added 3 commits
September 17, 2018 19:27
Python docs recommend to add properties to namespace, this allows for parsers to be reused.
attribute wouldn't be set without any metadata args. also removes the need to check for AttributeError
Contributor
Author
|
Sorry, this was an old PR. When I tried to merge the current master, I accidentally reverted some whitespace related changes from master. I rebased my commits onto master which fixed the whitespace issues. |
acdha
approved these changes
Sep 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, metadata items are assigned to a dict that is stored as an attribute of the argument parser. The proper solution would be to assign the dict to the argument namespace, which is also the way the Python docs suggest.
Also, the generation of default values directly on the argument namespace is suppressed to not litter it with
Nonevalues.