Highlight downsides of toTitlecase #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostephens
requested changes
Oct 21, 2022
katrinleinweber
force-pushed
the
243-note-transformation-side-effects
branch
from
dfa8a22 to
4e48d91
Compare
katrinleinweber
force-pushed
the
243-note-transformation-side-effects
branch
from
4e48d91 to
5fcf9dd
Compare
ostephens
requested changes
Oct 25, 2022
Co-authored-by: Owen Stephens <owen@ostephens.com>
katrinleinweber
force-pushed
the
243-note-transformation-side-effects
branch
from
5fcf9dd to
16f101d
Compare
zkamvar
pushed a commit
that referenced
this pull request
May 1, 2023
…side-effects Highlight downsides of toTitlecase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements one possible resolution to our discussion in #243.