-
-
Notifications
You must be signed in to change notification settings - Fork 66
link to GitHub guide on contributing to a project #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Generally I'd suggest hyperlinks better done with meaningful text rather than just the URL but I see you are just replacing the existing link in the same style. This might be an issue the lesson wants to consider more generally
|
Ideally this would be reviewed by a lesson maintainer before it's merged @LibraryCarpentry/lc-git-maintainers |
|
Thank you for the review, @ostephens 🙌
Honestly, I think the exercise text could be generally expanded and improved. I think that would be a great contribution for someone else in the community to make. I've tried to keep my changes here to a minimum just to remove the broken link, and will open a |
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tobyhodges , I have a minor stylistic revision for you to consider.
|
Great suggestions, thanks @emcaulay. I have updated the wording and hope this is ready to merge now. |
|
Thank you so much for the work to make this improvement! |
…allenge-link link to GitHub guide on contributing to a project
Fixes #128 by replacing the broken link to the Thinkful tutorial with a more up-to-date resource on forking, cloning, and pull requests. Hopefully this guide from GitHub is a safer bet in terms of long-term maintenance and availability.