Skip to content

Conversation

@tobyhodges
Copy link
Member

Fixes #128 by replacing the broken link to the Thinkful tutorial with a more up-to-date resource on forking, cloning, and pull requests. Hopefully this guide from GitHub is a safer bet in terms of long-term maintenance and availability.

@tobyhodges tobyhodges added the type:bug Code included in the lesson needs to be fixed label Oct 19, 2022
@tobyhodges tobyhodges requested a review from ostephens October 19, 2022 12:23
Copy link

@ostephens ostephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Generally I'd suggest hyperlinks better done with meaningful text rather than just the URL but I see you are just replacing the existing link in the same style. This might be an issue the lesson wants to consider more generally

@ostephens
Copy link

Ideally this would be reviewed by a lesson maintainer before it's merged @LibraryCarpentry/lc-git-maintainers

@ostephens ostephens requested a review from emcaulay October 19, 2022 14:12
@tobyhodges
Copy link
Member Author

tobyhodges commented Oct 19, 2022

Thank you for the review, @ostephens 🙌

Generally I'd suggest hyperlinks better done with meaningful text rather than just the URL but I see you are just replacing the existing link in the same style.

Honestly, I think the exercise text could be generally expanded and improved. I think that would be a great contribution for someone else in the community to make. I've tried to keep my changes here to a minimum just to remove the broken link, and will open a good-first-issue/help-wanted issue to suggest polishing the exercise.

Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Copy link
Contributor

@emcaulay emcaulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tobyhodges , I have a minor stylistic revision for you to consider.

@tobyhodges
Copy link
Member Author

Great suggestions, thanks @emcaulay. I have updated the wording and hope this is ready to merge now.

@emcaulay
Copy link
Contributor

Thank you so much for the work to make this improvement!

@emcaulay emcaulay merged commit 99c742d into gh-pages Oct 19, 2022
@emcaulay emcaulay deleted the 128-replace-optional-challenge-link branch October 19, 2022 18:51
zkamvar pushed a commit that referenced this pull request Apr 21, 2023
…allenge-link

link to GitHub guide on contributing to a project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Code included in the lesson needs to be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optional Challenge 1: 404'd

5 participants