Update 03-sharing.md #126
Merged
Update 03-sharing.md #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remote verbose text displayed as HTTPS, but new instructions are adding it as ssh. Adjusted to match.
tobyhodges
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Since the lesson was updated to use SSH keys (after GitHub dropped support for password authentication on the command line in 2020), addresses for remote repositories do need to be changed to match what a learner will see when following the lesson. This change makes that update, and it looks good to me, so I think you can go ahead and merge @emcaulay @LibraryCarpentry/lc-git-maintainers
|
I agree with you, @tobyhodges , and I thank you , @quist00 ! Very important and necessary change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote verbose text displayed as HTTPS, but new instructions are adding it as ssh. Adjusted to match.