Skip to content

Bindable dropdown #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 26, 2023
Merged

Bindable dropdown #31

merged 11 commits into from
Jun 26, 2023

Conversation

VasilevMaxim
Copy link
Contributor

Hi! I would like to help the development of the project and participate in the development.🔥
I thought that adding dropdownField as a standard element in UnityMvvmToolkit would be very useful!
I will be glad of any criticism and corrections)

ChebanovDD
ChebanovDD reviewed Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@ChebanovDD ChebanovDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request. There are a couple of thoughts on this.

@ChebanovDD ChebanovDD added the enhancement New feature or request label Jun 12, 2023
@VasilevMaxim
Copy link
Contributor Author

@ChebanovDD Good afternoon! What else needs to be fixed so that the changes can get into develop?

@ChebanovDD ChebanovDD merged commit e3de756 into LibraStack:develop Jun 26, 2023
@ChebanovDD ChebanovDD mentioned this pull request Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChebanovDD ChebanovDD ChebanovDD left review comments

Assignees

@VasilevMaxim VasilevMaxim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VasilevMaxim @ChebanovDD