SIP2: Expired card crashes client

[kkalmanigyuk]

Describe the bug
I have a patron account set up for SIP2 testing. I am modifying SIP2 settings in libki_local.conf, the current settings are attached to this report.

When a login attempt is made with a new user with and expired patron ID, it is denied with the error message: Username and password do not match. The patron's details don't get pulled into the users tab.

If I change the patron expiration date maunally to a future date in the ILS, the user can log into the client without any problems and patron details are imported into the user database with SIP as creation source.

However, if I make the patron expired again by manually setting an expired date in the ILS and try to log in again into the client, the client crashes. If I delete the users with expired patron ID first, and then try again to log in, "Username and password do not match" pops up, so I guess SIP2 is working again.

I have yet to test whether this would cause a problem with memberships expiring overnight.

The error the client is displaying:
Error connecting to server. Verifiy Libki server is accessible from this network. Error Code: 401: Error downloading http://[IP]:[PORT]/api/client/v1_0?node=[clientname]&location=[locationname]

By using a SIP testing tool I get the following response:
--> 2300120250522 154913AO|AA0310000000253|AC|AD0213|AY0AZF30D
<-- 24 Y 00120250522 154805AOtmkodb|AA0310000000253|AELibki Teszt|BLY|CQY|BHHUF|BV0.0|AY0AZE5DB

BL field carries the validity, Y is vaild, N is expired.

SIP config_Corvina_HU.pdf

Deployment architecture:

• OS: Linux Ubuntu Desktop 22.04
• Deployment style: VM
• Oracle Virtualbox 7.0
• Libki server: 4.9.1
• Libki client 2.2.32

[kkalmanigyuk]

Tested it with a "naturally" expiring patron, the error is the same. However it is not a crash, the client window simply gets oversized, but the fields are stil editable, so you can type in a valid patron ID and password, that makes the login window return to normal. Backdoor password works as well.

[kylemhall]

Can you tell us which ILS you are using?

[kkalmanigyuk]

Our library uses Corvina, it's a Java based ILS developed by Monguz Ltd. in Hungary.

[kkalmanigyuk]

The problem can be circumvented by using a script that deletes SIP users that are not Troublemakers on a nightly basis, running in tandem with libki_nightly.pl . History and statistics remain untouched.

I still have no proper solution, though, but I keep in touch with the developers of Corvina to find where the problem lies.

[kkalmanigyuk]

I've sort of found a way in SIP.pm to remedy this. All I had to do was to add USE JSON qw(to_json); at the end of the imported modules in the beginning, and now of a formerly valid user turns invalid the client won't get server error.

However such users will be deleted from the Libki database, which makes Troublemakers irrelevant, as they get deleted eventually and will start anew.

What would be nice is an update in the database column called notes. If user has an expired card and exist in the database already, notes should say "Expired card" instead of deletion.