Store Metadata as Values #99
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in OneSubjectEMaGerDataset for regression tasks. Updated for new Dataset format.
Return value of prepare_data was changed to a dictionary, which would be a breaking change. Modified this so users can pass in a flag that will determine if it is returned as a dictionary or a data handler.
Started working on Hyser dataset. Created parent class and started 1DOF class. Both classes still need to be tested.
Parameter passed to scipy zoom created a value for each column instead of one for each axis. This didn't throw an error in the past because most data that had been tested was also 2 DOF. Modified to proper zoom factor.
…to dataset_updates
eeddy
force-pushed
the
dataset_updates
branch
29 times, most recently
from
ceab009 to
371ea73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to this point we have stored metadata as the index in the list of potential values that the user passes in. This was done to reduce memory usage for things like strings. This can lead to confusing behaviour, particularly when isolating data (e.g., you want to isolate rep 2, but its index is 1 due to Python indexing).
These changes allow the user to store metadata as the values themselves instead of the indices. To avoid breaking previous code, the option to store as indices is still supported (and enabled by default).