Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows builds in GitHub Actions fail #32

Open
Liam-Deacon opened this issue Jan 14, 2024 · 2 comments
Open

Windows builds in GitHub Actions fail #32

Liam-Deacon opened this issue Jan 14, 2024 · 2 comments
Assignees
@Liam-Deacon
Labels
bug Something isn't working todo 🗒️

Comments

@Liam-Deacon
Copy link
Owner

Currently Windows builds fail when doing import phaseshifts.lib.libphsh due to: "ImportError: DLL load failed while importing libphsh: The specified module could not be found." which should be addressed to allow proper automated testing.
@Liam-Deacon Liam-Deacon added bug Something isn't working todo 🗒️ labels Jan 14, 2024
@Liam-Deacon Liam-Deacon self-assigned this Jan 14, 2024
@Liam-Deacon
Copy link
Owner Author

For clarity this is not a f2py build issue and is an error when attempting to import the library (despite the library existing)

@Liam-Deacon
Copy link
Owner Author

Likely related to missing DLLs, see https://vinayak.io/2020/10/21/day-51-bundling-dlls-with-windows-wheels-the-package-data-way/

@Liam-Deacon Liam-Deacon mentioned this issue Jan 21, 2024
Open
Liam-Deacon added a commit that referenced this issue Jan 23, 2024
@Liam-Deacon
build: Add python utils for creating phsh progs
fc9db0d 
Related to:

- #32
- #86
@Liam-Deacon Liam-Deacon mentioned this issue Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Liam-Deacon Liam-Deacon

Labels
bug Something isn't working todo 🗒️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Liam-Deacon