Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Yew 0.20 #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update to Yew 0.20 #1

wants to merge 2 commits into from

Conversation

aknarts
Copy link

@aknarts aknarts commented Dec 7, 2022

Hey, ran into the crate while working on something and wanted to use it.. made some changes internally for me, and then decided that I might as well push them upstream. This is currently still WIP.

What I want to do before merging is remove any hardcoded css from the core library and make it configurable.

@aknarts aknarts marked this pull request as draft December 7, 2022 01:16
@aknarts aknarts marked this pull request as ready for review December 10, 2022 22:49
@aknarts
Copy link
Author

aknarts commented Dec 12, 2022

This should be ready now.

@shimwell
Copy link

I just stumbled across this repo and pr while looking for a rust table.

I notice yew has been update to 0.21.0 recently.

The other changes in this pr include adding search which looks super useful

serde-value = "0.6.0"
yew = "0.6.0"
serde-value = "0.7.0"
yew = "0.20.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
yew = "0.20.0"
yew = "0.21.0"

@@ -14,5 +14,5 @@ description = "A table component for the Yew web framework"

[dependencies]
serde = { version = "1.0.93", features = ["derive"] }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
serde = { version = "1.0.93", features = ["derive"] }
serde = { version = "1.0.197", features = ["derive"] }

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, these are outdated because that is how long this PR was open :). It should pretty much just work as is. even with the update. I just have a copy of this in my projects...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shimwell I ended up creating a new repo with this if you want to use it https://github.com/aknarts/yew-custom-components did not publish yet because I am not sure I can take that name and trying to think of a better one. The table example is live here: https://aknarts.github.io/yew-custom-components/#/table

Rewrote it to Function Component, and added the ability for the data to be updated in real time and the table preserves sorting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants