Skip to content

Commit

Permalink
ANDROID: GKI: scripts: Makefile: update the lz4 command (#2)
Browse files Browse the repository at this point in the history
When the command was switched over from 'lz4c' to 'lz4', it changed the
meaning of '-c' in a subtle way. In the older lz4c tool, this '-cX'
seems to be a different flag, meaning the compression level. In the
newer lz4 tool, it means to compress to stdout. However, since kbuild
already specifies stdout as a file name, '-c' is superfluous, and
generates a warning:

Warning : stdout won't be used ! Do you want multiple input files (-m) ?

Fix it by removing the extra stdout flag.

Bug: 159285792
Bug: 160031736
Test: build/build.sh
Signed-off-by: Alistair Delva <adelva@google.com>
Change-Id: I96247317ccb31f224c6a8e6e453cddde5e0c2550
  • Loading branch information
adelva1984 committed Jul 2, 2020
1 parent 513f6ad commit 9fc96c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/Makefile.lib
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ cmd_lzo = (cat $(filter-out FORCE,$^) | \

quiet_cmd_lz4 = LZ4 $@
cmd_lz4 = (cat $(filter-out FORCE,$^) | \
lz4 -c -l -12 --favor-decSpeed stdin stdout && \
lz4 -l -12 --favor-decSpeed stdin stdout && \
$(call size_append, $(filter-out FORCE,$^))) > $@ || \
(rm -f $@ ; false)

Expand Down

0 comments on commit 9fc96c1

Please sign in to comment.