This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the (currently disabled)
create-stream-vs-put-racecondition.js
test inlevelup
(Level/levelup#497). That test was originally meant forleveldown
I believe, before it had snapshots. Today, it's more relevant formemdown
, which is secretly synchronous. E.g. it does (simplified):Rather than:
Before this PR, if you did the following on a deferred db:
Then on the underlying db it would actually be executed as if you did:
Which in the case of
memdown
, because it is synchronous, means the put was written before the iterator (snapshot) is created. Does it matter? Probably not a whole lot, but I think this PR makes for a less surprising behavior.