Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear() #310

Merged
merged 4 commits into from
Aug 18, 2019
Merged

Add clear() #310

merged 4 commits into from
Aug 18, 2019

Conversation

vweevers
Copy link
Member

Start of #236. For early feedback (see comments in code).

@vweevers vweevers self-assigned this Oct 19, 2018
@vweevers
Copy link
Member Author

@ralphtheninja Updated. Could you have a look? Tests are yet to do, but I'd first like a review of the general approach, taking into account Level/memdown#191 and Level/level-js#174.

@vweevers vweevers added enhancement New feature or request semver-minor New features that are backward compatible labels Aug 14, 2019

function warn (msg) {
if (typeof process !== 'undefined' && process && process.emitWarning) {
process.emitWarning(msg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL!

@vweevers
Copy link
Member Author

Done. Tested against Level/memdown#191.

@vweevers vweevers changed the title [WIP] Add clear() Add clear() Aug 17, 2019
@vweevers
Copy link
Member Author

Once Level/memdown#191 lands in master I'll make a canary branch there to run browser tests as well.

vweevers added a commit to Level/memdown that referenced this pull request Aug 17, 2019
vweevers added a commit to Level/leveldown that referenced this pull request Aug 18, 2019
@vweevers vweevers merged commit d102ad0 into master Aug 18, 2019
@vweevers vweevers deleted the clear branch August 18, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver-minor New features that are backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants