Skip to content

Fix return types of .get .getMany .nextv .all#91

Merged
vweevers merged 1 commit into
Level:mainfrom
yoursunny:typing
Dec 9, 2024
Merged

Fix return types of .get .getMany .nextv .all#91
vweevers merged 1 commit into
Level:mainfrom
yoursunny:typing

Conversation

@yoursunny
Copy link
Copy Markdown
Contributor

fixes #86

Copy link
Copy Markdown
Member

@vweevers vweevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Ignore the test failures, I don't agree with ts-standard's choice here (on "Array type using 'T[]' is forbidden for non-simple types") and I want to remove it anyway.

@vweevers vweevers merged commit bbcfb04 into Level:main Dec 9, 2024
@vweevers vweevers mentioned this pull request Dec 9, 2024
@vweevers
Copy link
Copy Markdown
Member

vweevers commented Dec 9, 2024

Released in 2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong Type declarations for .all() and .nextv() methods AbstractKeyIterator and AbstractValueIterator

2 participants