-
-
Notifications
You must be signed in to change notification settings - Fork 8
Add builtin sublevels ✨ #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8b842a5
Add builtin sublevels :sparkles:
vweevers 3083e93
Bump `level-supports` and remove unused manifest properties
vweevers 6cfb6d3
Freeze default options to prevent mutation
vweevers c1f3230
Improve `README.md` and `UPGRADING.md`
vweevers bb51886
Bump devDependencies
vweevers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
'use strict' | ||
|
||
exports.AbstractLevel = require('./abstract-level').AbstractLevel | ||
exports.AbstractSublevel = require('./abstract-level').AbstractSublevel | ||
exports.AbstractIterator = require('./abstract-iterator').AbstractIterator | ||
exports.AbstractChainedBatch = require('./abstract-chained-batch').AbstractChainedBatch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
'use strict' | ||
|
||
const { AbstractIterator } = require('../abstract-iterator') | ||
|
||
const kUnfix = Symbol('unfix') | ||
const kIterator = Symbol('iterator') | ||
const kNext = Symbol('next') | ||
const kCallback = Symbol('callback') | ||
|
||
class AbstractSublevelIterator extends AbstractIterator { | ||
constructor (db, options, iterator, unfix) { | ||
super(db, options) | ||
|
||
// TODO: do this natively if db supports it | ||
this[kUnfix] = unfix | ||
this[kIterator] = iterator | ||
this[kNext] = this[kNext].bind(this) | ||
this[kCallback] = null | ||
} | ||
|
||
_next (callback) { | ||
this[kCallback] = callback | ||
this[kIterator].next(this[kNext]) | ||
} | ||
|
||
[kNext] (err, key, value) { | ||
const callback = this[kCallback] | ||
if (err) return callback(err) | ||
if (key !== undefined) key = this[kUnfix](key) | ||
callback(err, key, value) | ||
} | ||
|
||
_seek (target, options) { | ||
this[kIterator].seek(target, options) | ||
} | ||
|
||
_close (callback) { | ||
this[kIterator].close(callback) | ||
} | ||
} | ||
|
||
exports.AbstractSublevelIterator = AbstractSublevelIterator |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the
and abstract-leveldown
because I'd also have to listencoding-down
,levelup
,deferred-leveldown
andsubleveldown
. Not sure how meaningful that is.@mafintosh I copied code from
subleveldown
to here. You're the copyright holder onsubleveldown
. Do you want your name in theLICENSE
file ofabstract-level
(or in code comments)?