Skip to content

Conversation

@khaledhosny
Copy link
Contributor

Fixes #85

@coveralls
Copy link

coveralls commented May 22, 2017

Coverage Status

Coverage decreased (-0.04%) to 88.609% when pulling 4d05265 on khaledhosny:unicodes into ace7445 on LettError:master.

@khaledhosny
Copy link
Contributor Author

Not sure if this breaks public API, if so we probably need to keep unicodeValue and provide another unicodes keyword argument similar to defcon. Also I think the old code was trying to detect different unicode values accross masters, which is probably not detected now.

@anthrotype
Copy link
Collaborator

the designSpaceDocument's specification should probably be modified as well to allow a list of unicode values for each glyph element, rather than a single one:

https://github.com/LettError/designSpaceDocument#attributes-7

@LettError LettError merged commit c05145b into LettError:master Jul 10, 2017
@anthrotype
Copy link
Collaborator

@khaledhosny @LettError so, does this change the attributes of glyph element (from unicode to unicodes) in the generated designspace? Shouldn't it be reflected in the spec?

btw, the designSpaceDocument still uses the old unicodeValue:
https://github.com/LettError/designSpaceDocument/blob/master/Lib/designSpaceDocument/__init__.py#L897-L900

@LettError
Copy link
Owner

Thanks @anthrotype, guess I'll need to fix that.

@LettError
Copy link
Owner

LettError commented Aug 25, 2017

I think I made all the right changes to support multiple unicode values in the glyph element in designSpaceDocument. Tests added.
https://github.com/LettError/designSpaceDocument/compare/unicodes
LettError/designSpaceDocument#21

anthrotype added a commit that referenced this pull request Oct 2, 2017
Allow multiple unicode values for glyphs (#86).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants