Skip to content

Conversation

@claasahl
Copy link

@claasahl claasahl commented Jun 4, 2018

Updated documentation of callbacks for "attrValueProcessors" and "valueProcessors" in section "Options" of README.md.

Before:

function (name){
  //do something with `name`
  return name
}

After:

function (value, name) {
  //`name` will be the node name or attribute name
  //do something with `value`, (optionally) dependent on the node/attr name
  return value
}

@coveralls
Copy link

coveralls commented Jun 4, 2018

Coverage Status

Coverage remained the same at 97.633% when pulling 3637fa1 on claasahl:master into d057cd9 on Leonidas-from-XIV:master.

Copy link
Contributor

@jcsahnwaldt jcsahnwaldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. The signature in the Options section was wrong. This patch copies the signature from the Processing attribute, tag names and values section, which is correct.

@jcsahnwaldt
Copy link
Contributor

This PR would have been a nice improvement, but it was closed without being merged. :-( I don't know why it wasn't merged...

@jcsahnwaldt
Copy link
Contributor

There's a similar (but less complete) PR now: #474

@Leonidas-from-XIV
Copy link
Owner

Well, let's go with #474 now, the code here is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants