Skip to content

Throw exception instead of just exiting #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Throw exception instead of just exiting #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/lib/Combiner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,7 @@ private function submitBatch() {
call_user_func($this->checkpointer,$result);
}
if(!$result['success']) {
/**
* @todo we need to kill this process osmehow
*/
exit();
throw new \Exception("Could not put message on bus - result is: " . $result);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$result is an array, an the way this is written, it would throw an Array to string conversion error. So either $result would have to be flattened, or use the element of result that you want to see in Exception.

}
}
}
Expand Down Expand Up @@ -170,4 +167,4 @@ public function end() {
$this->reset();
$this->uploader->end();
}
}
}