Feature/faster stream parsing #188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed but with webpack removing require in aws-sdk-sync.ts Added WriteOptions.onCheckpoint - called when checkpoint is called in a toLeo Added ReadOptions.parser to provide a custom parser Added ReadOptions.hooks to allow extending the fromLeo stream Added sdk.streams.tmpDir which defaults to `/tmp/rstreams`
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
czirker
commented
Sep 28, 2023
| split((value) => { | ||
| try { | ||
| let obj = JSONparse(value); | ||
| if (obj.size == null) { |
There was a problem hiding this comment.
This is take care in JSONpare so it shouldn't be needed here
czirker
commented
Sep 28, 2023
lib/stream/leo-stream.js
Outdated
| file.range = `bytes=${fileOffset}-${fileEnd}`; | ||
| logger.debug(file.bucket, file.key, file.range); | ||
| s3Stream = ls.fromS3(file); | ||
| let localFile = path.resolve(ls.tmpDir, `s3/${item.s3.key.replace(".gz", "")}-${fileOffset}-${fileEnd}.jsonl.gz`); |
There was a problem hiding this comment.
Review all localFile locations. They should have the queue
Passing s3 credentials to the task removed merge file V2 Better support for FastJson - handle wildcards '*' and arrays
…-webpack Feature/faster stream parsing webpack
| // If there are multiple files then merge them into the one desired file | ||
| if (!error && subFiles.length > 1) { | ||
| try { | ||
| execSync(`cat ${subFiles.map(p => basename(p).replace(/\\/g, "/")).join(" ")} >> ${task.filePath}`, { |
Check warning
Code scanning / CodeQL
Shell command built from environment values
Added 16.x and 18.x node ci/cd
Bug/faster stream parsing fixes
…ip data to prevent an write after destroy error
Fix config builder when an object isn't actually a ref
Fixing mem leak, uncaught exceptions, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.