Incorrect sizing of artwork images in popup bar.

[llsc12]

Describe the Bug:

Sometimes the image grows really large over all of the popup bar, sometimes it appears to not be in the view hierarchy at all or has odd sizing issues in general.

Reproduction:

This is the code I used to try and get it working. When the second part is uncommented, the image doesn't seen to show up at all.

Expected Behavior:

Square images were fine until the issue arose in newer library versions.

Other sized images should fit within the same square space, but the shadow and rounding should wrap correctly to the image frame like this.

Screenshots and/or Videos:

Here's a link to the video as GitHub refuses to upload it.
https://share.boba.best/raw/kPJsJOT9

Additional Context:

No response

[LeoNatan]

I will need a demo project with those images if possible. I don’t need the music playing, just rotating between the images.
Thanks

[LeoNatan]

As a workaround, you can restore the old behavior by setting aspect ratio 1.0 and content mode to fill.

[llsc12]

It seems that the workaround doesn't work for me, but here's a demo app.

Archive.zip

[LeoNatan]

I see two issues, one of which has to be fixed in LNPopupController, and that's limiting the size of SwiftUI images to the actual maximum square size. That was missing for SwiftUI. Another issue I see is that somehow SwiftUI reports the wrong size for the next image. Investigating. In general, it's very difficult to obtain accurate sizing information from SwiftUI hosting views.

[LeoNatan]

Cool, I have a fix for the second issue as well. Both in LNPopupController, so moving the issue to there.

[LeoNatan]

Please try with LNPopupUI 1.9.5

[llsc12]

Works almost perfectly! Thanks very much, however there is a minor issue after further testing with images that are taller than they are wide. I think I didn't include this in the demo project, my apologies.

[LeoNatan]

That behaves correctly. I played around with centering the image view within the max square rect, and did not like how it looked.