This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Bugfix for resource serialization #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tring. Extract tha data serialization into trait so it can be potentially reused. This bumps the minimum supported PHP version to 5.4
ppamment
reviewed
Nov 10, 2017
| $data = ''; | ||
| try { | ||
| $data = serialize($nonObject); | ||
| } catch (\Throwable $t) { |
Member
Author
There was a problem hiding this comment.
Yes, this will work in the old-fashioned way where line 85 errors and nothing is caught.
This amendment doesn't change the existing behaviour on PHP 5.x and improves only when running on 7.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the data serialization into trait so it can be potentially reused. This bumps the minimum supported PHP version to 5.4