Skip to content

Solve #138 Deletar Ajuda #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lucasdutraf merged 5 commits into from
Apr 29, 2021
Merged

Solve #138 Deletar Ajuda #25

lucasdutraf merged 5 commits into from
Apr 29, 2021

Conversation

@Thais-ra
Copy link
Contributor

@Thais-ra Thais-ra commented Apr 24, 2021

Issues

Descrição

Filtragem e teste das rotas:

  • get_all_available_requests
  • get_requests_filtered

Como testar ou reproduzir

Rotas:
Rodar o microserviço de Request, e fazer uma requisição das rotas.

Testes:
Rodar os testes usando o comando make test.

Tipos de mudança

  • Bugfix
  • Melhoria de funcionalidade
  • Nova funcionalidade
  • Documentação

Checklist

  • Lint e testes passaram localmente com minhas mudanças
  • Eu adicionei testes que provam que minha correção é eficaz ou que minha feature funciona
  • Adicionei informações necessárias na documentação (se precisar)

Observações adicionais

A rota get_all_request não foi alterada.

Thais-ra and others added 4 commits April 22, 2021 23:47
@Thais-ra @thiagompc @mateusmaiamaia
feat: fga-eps-mds/2020.2-Lend.it#138 Added end date as filter in the …
1e028ac 
…get_all_available_requests

Co-authored-by: Thiago Mesquita <thiago099carvalho@gmail.com>
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
@Thais-ra @thiagompc @mateusmaiamaia
refactor: fga-eps-mds/2020.2-Lend.it#138 Refactored get requests filt…
d2f1ce8 
…ered by category route

Co-authored-by: Thiago Mesquita <thiago099carvalho@gmail.com>
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
@Thais-ra @thiagompc @mateusmaiamaia
test: fga-eps-mds/2020.2-Lend.it#138 Route and name changed in the te…
1563bfa 
…st get requests filtered by category

Co-authored-by: Thiago Mesquita <thiago099carvalho@gmail.com>
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
@Thais-ra @thiagompc @mateusmaiamaia
test: fga-eps-mds/2020.2-Lend.it#138 Created test for get all availab…
8b7263d 
…le requests and not available requests

Co-authored-by: Thiago Mesquita <thiago099carvalho@gmail.com>
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
@Thais-ra Thais-ra requested a review from lucasdutraf April 24, 2021 02:09
@lucasdutraf @Thais-ra
@thiagompc @mateusmaiamaia
perf: fga-eps-mds/2020.2-Lend.it#138 Update datetime now method
8316ace 
Co-authored-by: Thais Reboucas <rotinasoftware@gmail.com>
Co-authored-by: Thiago Mesquita <thiago099carvalho@gmail.com>
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
lucasdutraf
lucasdutraf approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@lucasdutraf lucasdutraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@lucasdutraf lucasdutraf merged commit 168f292 into devel Apr 29, 2021
@lucasdutraf lucasdutraf deleted the 138_deletar_ajuda branch April 29, 2021 02:03
@youssef-md youssef-md mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasdutraf lucasdutraf lucasdutraf approved these changes

Assignees

@Thais-ra Thais-ra

@mateusmaiamaia mateusmaiamaia

@thiagompc thiagompc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[US15] Deletar ajuda

4 participants

@Thais-ra @lucasdutraf @mateusmaiamaia @thiagompc