Skip to content

Solve 121 ajudar solicitacao #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lucasdutraf merged 8 commits into from
Apr 3, 2021
Merged

Solve 121 ajudar solicitacao #17

lucasdutraf merged 8 commits into from
Apr 3, 2021

Conversation

@Matheusafonsouza
Copy link
Contributor

@Matheusafonsouza Matheusafonsouza commented Apr 3, 2021 •
edited by lucasdutraf
Loading

Solve ajudar solicitacao

Issues

Descrição

Acrescentamento do campo finalized no banco e criação do método para finalizar request

Como testar ou reproduzir

rode a aplicação e execute a rota /requests/:requestid/finalize

Tipos de mudança

  • Bugfix
  • Melhoria de funcionalidade
  • Nova funcionalidade
  • Documentação

Checklist

  • Lint e testes passaram localmente com minhas mudanças
  • Eu adicionei testes que provam que minha correção é eficaz ou que minha feature funciona
  • Adicionei informações necessárias na documentação (se precisar)

Matheusafonsouza and others added 5 commits April 2, 2021 23:03
@Matheusafonsouza @rogerioo @mateusmaiamaia
feat: fga-eps-mds/2020.2-Lend.it#121 add finalized field to request s…
5a8acf5 
…ql file

Co-authored-by: Rogério Júnior <junior.rogerio8@gmail.com>
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
@Matheusafonsouza @mateusmaiamaia
chore: fga-eps-mds/2020.2-Lend.it#121 add finalized field on model
7ad78bc 
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
@Matheusafonsouza @mateusmaiamaia
feat: fga-eps-mds/2020.2-Lend.it#121 create finalize request method
ca9de6b 
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
@Matheusafonsouza @mateusmaiamaia
chore: fga-eps-mds/2020.2-Lend.it#121 fix request constructor
50c9f42 
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
@Matheusafonsouza @mateusmaiamaia
feat: fga-eps-mds/2020.2-Lend.it#121 create finalize request tests
34c2cd9 
Co-authored-by: Mateus Maia <mateusmaiamaia@hotmail.com>
@Matheusafonsouza Matheusafonsouza requested review from lucasdutraf and rogerioo and removed request for rogerioo April 3, 2021 02:44
@lucasdutraf lucasdutraf force-pushed the 121_ajudar_solicitacao branch from 6a9dba9 to 81713a5 Compare April 3, 2021 16:06
@lucasdutraf lucasdutraf force-pushed the 121_ajudar_solicitacao branch from 1f3f568 to 6cbf14a Compare April 3, 2021 17:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
1.1% 1.1% Duplication

lucasdutraf
lucasdutraf approved these changes Apr 3, 2021
View reviewed changes
Copy link
Member

@lucasdutraf lucasdutraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well done rapeize

@lucasdutraf lucasdutraf merged commit 452f6f5 into devel Apr 3, 2021
@lucasdutraf lucasdutraf deleted the 121_ajudar_solicitacao branch April 3, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasdutraf lucasdutraf lucasdutraf approved these changes

@rogerioo rogerioo Awaiting requested review from rogerioo

Assignees

@Matheusafonsouza Matheusafonsouza

@mateusmaiamaia mateusmaiamaia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[US16] - ajudar solicitação

5 participants

@Matheusafonsouza @lucasdutraf @EsioFreitas @rogerioo @mateusmaiamaia