Feature/84 improve get form validation result.field errors #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brauliodiez
reviewed
Aug 28, 2018
| /*{ | ||
| firstName: { succeeded: true, type: "REQUIRED", key: "firstName", errorMessage: "" }, | ||
| lastName: { succeeded: true, type: "REQUIRED", key: "lastName", errorMessage: "" } | ||
| }*/ |
Member
There was a problem hiding this comment.
I don't remember what was the intention when we create the readme about this commented code, dou you know why?
Member
There was a problem hiding this comment.
I see it's dumping the result, it's from a previous version (even previous that current)
brauliodiez
reviewed
Aug 28, 2018
| constructor() { | ||
| this.succeeded = false; | ||
| this.fieldErrors = []; | ||
| this.fieldErrors = {}; |
Member
There was a problem hiding this comment.
MMM... I think this is a breaking change, should we go for a major release?
Member
Author
There was a problem hiding this comment.
Yes, I think it should be major
nasdan
deleted the
feature/84-Improve-get-formValidationResult.fieldErrors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.