Skip to content
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions lib/lcformvalidation.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,16 @@ export class FormValidationResult {
formGlobalErrors: Array<FieldValidationResult>;
}

export interface ValidationFilters {
[key: string]: boolean;
}

interface FormValidation {
validateField(vm: any, key: string, value: any, filter?: any): Promise<FieldValidationResult>;
validateField(vm: any, key: string, value: any, filter?: ValidationFilters): Promise<FieldValidationResult>;
validateForm(vm: any): Promise<FormValidationResult>;
isValidationInProgress(): boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type => validateField(vm: any, key: string, value: any, filter?: ValidationFilter): Promise;

isFormDirty(): boolean;
isFormPristine(): boolean;
addFieldValidation(key: string, validation: (value: string, vm: any) => FieldValidationResult, filter?: any): FormValidation;
addFieldValidationAsync(key: string, validation: (value: string, vm: any) => Promise<FieldValidationResult>, filter?: any): FormValidation;
}

export type ValidationResult = FieldValidationResult | Promise<FieldValidationResult>;
Expand All @@ -27,8 +29,19 @@ export interface FormValidationFunction {
(vm: any): ValidationResult;
}

export interface FieldValidationFunction {
(value: any, vm: any, customParams: any): ValidationResult;
}

export interface FieldValidationConstraint extends Object {
validator: FieldValidationFunction;
eventFilters?: ValidationFilters,
customParams?: Object
}

export interface ValidationConstraints extends Object {
global?: FormValidationFunction[];
fields?: { [key: string]: FieldValidationConstraint[] }
}

export function createFormValidation(validationCredentials: ValidationConstraints): FormValidation;
export function createFormValidation(validationCredentials: ValidationConstraints): FormValidation;
4 changes: 2 additions & 2 deletions lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "dist/lc-form-validation.js",
"scripts": {
"test": "karma start --browsers PhantomJS --single-run",
"test:watch": "karma start --browsers PhantomJS",
"test:watch": "karma start",
"clean": "rimraf dist ReadmeResources",
"build:prod": "cross-env NODE_ENV=production webpack --output-filename dist/lc-form-validation.min.js",
"build:dev": "cross-env NODE_ENV=development webpack --output-filename dist/lc-form-validation.js",
Expand All @@ -31,7 +31,7 @@
"devDependencies": {
"@types/chai": "^3.4.35",
"@types/chai-as-promised": "^0.0.30",
"@types/core-js": "^0.9.34",
"@types/core-js": "0.9.36",
"@types/karma-chai-sinon": "^0.1.5",
"@types/mocha": "^2.2.39",
"@types/sinon": "^1.16.31",
Expand Down
58 changes: 40 additions & 18 deletions lib/src/baseFormValidation.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
import { ValidationEngine } from './validationEngine';
import {
ValidationConstraints,
FieldValidationFunction,
FormValidationFunction,
FieldValidationResult,
FormValidationResult,
FieldValidationConstraint,
ValidationFilters,
} from './entities';
import { consts } from './consts';

Expand All @@ -13,35 +16,64 @@ interface FormValidation {
isValidationInProgress(): boolean;
isFormDirty(): boolean;
isFormPristine(): boolean;
addFieldValidation(key: string, validation: (value: string, vm: any) => FieldValidationResult, filter?: any): FormValidation;
addFieldValidationAsync(key: string, validation: (value: string, vm: any) => Promise<FieldValidationResult>, filter?: any): FormValidation;
}

export class BaseFormValidation implements FormValidation {
private validationEngine: ValidationEngine;

constructor(validationConstraints: ValidationConstraints) {
this.validationEngine = new ValidationEngine();
this.parseValidationConstraints(validationConstraints);
}

private parseValidationConstraints(validationConstraints: ValidationConstraints) {
if (validationConstraints && typeof validationConstraints === 'object') {
if (validationConstraints.global && validationConstraints.global instanceof Array) {
this.addFormValidationFunctions(validationConstraints.global);
const { global, fields } = validationConstraints;
if (global && global instanceof Array) {
this.parseFormValidations(global);
}
if (fields && typeof fields === 'object') {
this.parseAllFieldsValidations(fields);
}
}
}

private addFormValidationFunctions(validationFunctions: FormValidationFunction[]) {
private parseFieldValidations(constraint: string, fieldValidationConstraints: FieldValidationConstraint[]) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here same as below

if (fieldValidationConstraints instanceof Array) {
fieldValidationConstraints.forEach((fieldValidationConstraint) => {
if (fieldValidationConstraint && typeof fieldValidationConstraint === 'object') {
this.addFieldValidation(constraint, fieldValidationConstraint);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to field

}
});
}
}

private parseAllFieldsValidations(fields: { [key: string]: FieldValidationConstraint[] }) {
for (let field in fields) {
this.parseFieldValidations(field, fields[field]);
}
}

private parseFormValidations(validationFunctions: FormValidationFunction[]) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer order methods like we are using:

if (global && global instanceof Array) {
        this.parseFormValidations(global);
      }
      if (fields && typeof fields === 'object') {
        this.parseAllFieldsValidations(fields);
      }
...

  private parseFormValidations(validationFunctions: FormValidationFunction[]) {
   .....
  }
  private parseAllFieldsValidations(fields: { [key: string]: FieldValidationConstraint[] }) {
     .....
  }

  private parseFieldValidations(constraint: string, fieldValidationConstraints: FieldValidationConstraint[]) {
   ...
  }

So, you don't have to scroll down to search what are doing for example parseFormValidations

validationFunctions.forEach((validationFunction: FormValidationFunction) => {
if (typeof validationFunction === 'function') {
this.validationEngine.addFormValidation(validationFunction);
}
});
}

validateField(vm: any, key: string, value: any, filter?: any): Promise<FieldValidationResult> {
return this.validationEngine.validateSingleField(vm, key, value, filter);
private addFieldValidation(constraint: string, validationConstraint: FieldValidationConstraint): FormValidation {
this.validationEngine.addFieldValidation(
constraint,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this constraint?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename to field?

validationConstraint.validator,
validationConstraint.eventFilters,
validationConstraint.customParams
);
return this;
}

validateField(vm: any, key: string, value: any, filter?: ValidationFilters): Promise<FieldValidationResult> {
return this.validationEngine.triggerFieldValidation(vm, key, value, filter);
}

validateForm(vm: any): Promise<FormValidationResult> {
Expand All @@ -59,18 +91,8 @@ export class BaseFormValidation implements FormValidation {
isFormPristine(): boolean {
return this.validationEngine.isFormPristine();
}

addFieldValidation(key: string, validationFunction: (value: string, vm: any) => FieldValidationResult): FormValidation {
this.validationEngine.addFieldValidation(key, validationFunction);
return this;
}

addFieldValidationAsync(key: string, validationFunction: (value: string, vm: any) => Promise<FieldValidationResult>): FormValidation {
this.validationEngine.addFieldValidationAsync(key, validationFunction);
return this;
}
}

export function createFormValidation(validationConstraints: ValidationConstraints): FormValidation {
return new BaseFormValidation(validationConstraints);
}
}
32 changes: 27 additions & 5 deletions lib/src/entities.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
export interface ValidationFilters {
[key: string]: boolean;
}

export class FieldValidation {
public validationFn: (value, vm) => Promise<FieldValidationResult>;
public filter: any;
validationFn: (value, vm, customParams) => Promise<FieldValidationResult>;
filters: ValidationFilters;
customParams: any;
}

export class FieldValidationResult {
Expand All @@ -19,8 +24,8 @@ export class FieldValidationResult {

export class FormValidationResult {
succeeded: boolean;
fieldErrors: Array<FieldValidationResult>;
formGlobalErrors: Array<FieldValidationResult>;
fieldErrors: FieldValidationResult[];
formGlobalErrors: FieldValidationResult[];

constructor() {
this.succeeded = false;
Expand All @@ -34,6 +39,23 @@ export interface FormValidationFunction {
(vm: any): ValidationResult;
}

export interface ValidationConstraints extends Object {
export interface SyncValidationFunction {
(value: any, vm: any, customParams: any): ValidationResult;
}

export interface AsyncFieldValidationFunction {
Copy link
Member

@nasdan nasdan Mar 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need defined SyncValidationFunction and AsyncFieldValidationFunction if we define interface like ValidationResult?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have enough if we only define this?

export interface FieldValidationFunction {
   (value: any, vm: any, customParams: any): ValidationResult;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this interface

(value: any, vm: any, customParams: any): Promise<FieldValidationResult>;
}

export type FieldValidationFunction = SyncValidationFunction | AsyncFieldValidationFunction;

export interface FieldValidationConstraint {
validator: FieldValidationFunction;
eventFilters?: ValidationFilters;
customParams?: any;
}

export interface ValidationConstraints {
global?: FormValidationFunction[];
fields?: { [key: string]: FieldValidationConstraint[] };
}
11 changes: 0 additions & 11 deletions lib/src/entitiesMapper.ts

This file was deleted.

34 changes: 11 additions & 23 deletions lib/src/fieldValidationEventFilter.ts
Original file line number Diff line number Diff line change
@@ -1,37 +1,25 @@
import { FieldValidation } from './entities';
import { FieldValidation, ValidationFilters } from './entities';

class FieldValidationEventFilter {

public filter(fieldValidations: Array<FieldValidation>, filter: any): Array<FieldValidation> {
let result = new Array<FieldValidation>();
public filter(fieldValidations: FieldValidation[], filters: ValidationFilters): FieldValidation[] {
let result: FieldValidation[] = [];

if (filter) {
result = fieldValidations.filter((element) => {
return this.matchFilterOr(element, filter)
});
if (filters) {
result = fieldValidations.filter((fieldValidation) =>
this.matchsAnyFilter(fieldValidation, filters)
);
} else {
result = fieldValidations;
}

return result;
}

private matchFilterOr(itemFilter, globalFilter) {
let result: boolean = false;

for (var property in globalFilter) {
if (this.propertyMatched(itemFilter, property, globalFilter)) {
result = true;
break;
}
}

return result;
}

private propertyMatched(item: any, property: any, globalFilter: any): boolean {
return (globalFilter.hasOwnProperty(property) &&
globalFilter[property] == item.filter[property]);
private matchsAnyFilter(fieldValidation: FieldValidation, filters: ValidationFilters) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches?

I think matchs is "cerillas"?

return Object.keys(filters).some(filter =>
filters[filter] === fieldValidation.filters[filter]
);
}
}

Expand Down
Loading