Replace inheritance with factory based and support for validationConstraints (global object) #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed formValidation as baseFormValidation.
…the same context.
nasdan
reviewed
Mar 9, 2017
lib/lcformvalidation.d.ts
Outdated
| (vm: any): ValidationResult; | ||
| } | ||
|
|
||
|
|
nasdan
reviewed
Mar 9, 2017
lib/package.json
Outdated
| "phantomjs-prebuilt": "^2.1.7", | ||
| "rimraf": "^2.5.2", | ||
| "sinon": "^1.17.6", | ||
| "sinon-chai": "^2.8.0", |
nasdan
reviewed
Mar 9, 2017
lib/lcformvalidation.d.ts
Outdated
| } | ||
| import { } from 'core-js'; | ||
|
|
||
| export class FormNameToFieldNameMapping { |
nasdan
reviewed
Mar 9, 2017
lib/lcformvalidation.d.ts
Outdated
| vmFieldName: string; | ||
| } | ||
|
|
||
| export class FieldValidation { |
Member
There was a problem hiding this comment.
I think we should remove this class too because this is an internal entity
nasdan
reviewed
Mar 9, 2017
lib/src/index.ts
Outdated
| import { createFormValidation } from './baseFormValidation'; | ||
|
|
||
| export { | ||
| FormNameToFieldNameMapping, |
nasdan
reviewed
Mar 9, 2017
lib/src/baseFormValidation.ts
Outdated
|
|
||
| private parseValidationConstraints(validationConstraints: ValidationConstraints) { | ||
| if (validationConstraints && typeof validationConstraints === 'object') { | ||
| if (validationConstraints.hasOwnProperty('global') && validationConstraints.global instanceof Array) { |
Member
There was a problem hiding this comment.
Why you use validationConstraints.hasOwnProperty('global')?
You can't use validationConstraints.global?
nasdan
reviewed
Mar 9, 2017
lib/src/baseFormValidation.ts
Outdated
| }); | ||
| } | ||
|
|
||
| validateField(vm: any, key: string, value: any, filter?: any) { |
Member
There was a problem hiding this comment.
Before refactor, this method looks like: filter: any = consts.defaultFilter).
Do you remove default value unintentionally?
Member
Author
There was a problem hiding this comment.
ValidationEngine already does it. It's unnecessary to do this twice.
nasdan
reviewed
Mar 9, 2017
lib/lcformvalidation.d.ts
Outdated
| constructor(); | ||
| } | ||
|
|
||
| export interface IValidationEngine { |
Member
There was a problem hiding this comment.
I think we should remove this interface too because this is an internal interface
nasdan
reviewed
Mar 9, 2017
lib/src/validationEngine.ts
Outdated
| import { } from 'core-js'; | ||
| import { FormNameToFieldNameMapping, FormValidationResult, FieldValidationResult, FieldValidation } from "./entities"; | ||
| import { | ||
| FormNameToFieldNameMapping, |
…porting chai-as-promised (used by Karma).
nasdan
reviewed
Mar 9, 2017
lib/src/validationEngine.ts
Outdated
| } | ||
|
|
||
| validateGlobalFormValidations(vm: any): Array<Promise<FieldValidationResult>> { | ||
| validateGlobalFormValidations(vm: any) { |
Member
There was a problem hiding this comment.
Pending to add returned type? Promise<FieldValidationResult>[]
Member
Author
There was a problem hiding this comment.
We need to discuss here if we should declare it for functions that already returns that value, e.g:
function isNotNull(object: any): boolean {
return object !== null;
}
function giveMeAPromiseWIthFieldValidationResult(someData: any): Promise<ValidationResult> {
return new Promise((resolve, reject) => {
const validationResult = new FieldValidationResult();
// do some logic here
resolve(validationResult);
});
}
nasdan
reviewed
Mar 9, 2017
lib/src/validationsDispatcher.ts
Outdated
| import { } from 'core-js'; | ||
| import { FormNameToFieldNameMapping, FieldValidationResult } from './entities'; | ||
| import { | ||
| FormNameToFieldNameMapping, |
nasdan
reviewed
Mar 10, 2017
lib/src/entities.ts
Outdated
| @@ -1,12 +1,7 @@ | |||
| import { } from 'core-js'; | |||
nasdan
approved these changes
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.