Skip to content

Invert validation function parameters order #42

@nasdan

Description

@nasdan

Most of validation function, especially simple validation, it's only using value parameter:

e.g:

./requiredValidation.ts

export const required => (vm, value) : FieldValidationResult => {
  return {
    type : 'REQUIRED',
    succeeded : (value && value.length > 0),
    errorMessage : 'Mandatory field',
  }
}

It could be more efficiently if we feed value as first parameter and vm as second optional one:
e.g:

./requiredValidation.ts

export const required => (value) : FieldValidationResult => {
  return {
    type : 'REQUIRED',
    succeeded : (value && value.length > 0),
    errorMessage : 'Mandatory field',
  }
}

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions