KON-650 Change KoGenericTypeDeclaration API#1410
Merged
Conversation
…rationProvider to KoGenericTypeProvider
…enerictypedeclaration-api # Conflicts: # lib/src/konsistTest/kotlin/com/lemonappdev/konsist/api/ApiKonsistTest.kt
12c9a9c to
6c6a19e
Compare
6c6a19e to
39f2f32
Compare
igorwojda
approved these changes
Oct 10, 2024
...core/declaration/type/kogenerictype/KoGenericTypeDeclarationForKoTypeArgumentProviderTest.kt
Show resolved
Hide resolved
lib/src/main/kotlin/com/lemonappdev/konsist/api/ext/list/KoGenericTypeProviderListExt.kt
Show resolved
Hide resolved
lib/src/main/kotlin/com/lemonappdev/konsist/api/ext/list/KoGenericTypeProviderListExt.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the code structure around type arguments and generic type providers, along with some breaking API changes to improve clarity and consistency.
Main Changes:
Added
KoTypeArgumentDeclarationKoTypeArgumentDeclarationto encapsulate type argument information.Example:
scope .functions() .returnTypes .genericTypeDeclarations() .typeArguments .assertTrue { ... }Breaking API Change: Modified
KoGenericTypeProviderisGenericTypeproperty fromKoGenericTypeProvider.genericType, enhancing the provider’s specificity.Example:
Removed
KoGenericTypeDeclarationProviderand Added New ProvidersKoGenericTypeDeclarationProviderwith two new providers:KoGenericTypeProvider– for handling generic type.KoTypeArgumentProvider– for managing type arguments specifically.Deprecated
declarationProperty and AddedsourceDeclarationdeclarationproperty to clarify the intent of referencing the declaration site.sourceDeclaration, which now consistently refers to the declaration site.Example: