Fixing jest failure tests, adding test for registration denied. #6267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
requested review from
Nutomic,
SleeplessOne1917,
dullbananas and
phiresky
as code owners
dessalines
commented
Jan 6, 2026
Comment on lines
-92
to
-95
| RegistrationDenied { | ||
| #[cfg_attr(feature = "ts-rs", ts(optional))] | ||
| reason: Option<String>, | ||
| }, |
Member
Author
There was a problem hiding this comment.
This was incorrect, and I fixed it.
| /// A remote community sent an activity to us, but actually no local user follows the community | ||
| /// so the activity was rejected. | ||
| CommunityHasNoFollowers(String), | ||
| ResolveObjectFailed(String), |
Member
Author
There was a problem hiding this comment.
Moved this to a standard LemmyError. Really UntranslatedError should only be for federation / internal errors. Anything that the API can potentially return should be a LemmyError
| new LemmyError( | ||
| "resolve_object_failed", | ||
| statusBadRequest, | ||
| 'Domain "lemmy-alpha" is not in allowlist', |
Member
Author
There was a problem hiding this comment.
Here's an example of the internal error message being returned and checked.
We don't actually have to show this in lemmy-ui, but it might be good to console log it there anyway.
Nutomic
approved these changes
Jan 7, 2026
Nutomic
added a commit
that referenced
this pull request
Jan 7, 2026
) * Return error details in HTTP response * separate error * make format of UntranslatedError match LemmyErrorType * Fixing jest failure tests, adding test for registration denied. (#6267) * Fixing jest failure tests, adding test for registration denied. * Fixing tests. --------- Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.