Add contenttypes to lazy columns #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
reviewed
Jul 10, 2023
app/src/main/java/com/jerboa/ui/components/community/list/CommunityList.kt
Outdated
Show resolved
Hide resolved
MV-GH
commented
Jul 19, 2023
| @@ -233,7 +233,7 @@ fun LazyListScope.commentNodeItem( | |||
| .commentView.counts.child_count > 0 && !isFlat | |||
|
|
|||
| increaseLazyListIndexTracker() | |||
| item(key = commentId) { | |||
| item(key = commentId, contentType = { "contentNodeItemL${node.depth}" }) { | |||
There was a problem hiding this comment.
Eh it's just this one that worries me, I ll leave this one out for now and when I get some more time I ll try to get a microbench for this, bc the macrobench currently is not showing any significant perf changes. Same was for the scrolling with baselines/without but from personal expercience the baselines make a bigger impact than they are showing from the tests. So they aren't very reliable imo.
There was a problem hiding this comment.
Gotcha. Yep I'm guessing these aren't going to really matter until we have combined lists, like putting all the notification types (messages, comment replies, and mentions), in a single LazyList.
# Conflicts: # app/src/main/java/com/jerboa/ui/components/common/Dialogs.kt # app/src/main/java/com/jerboa/ui/components/home/Home.kt # app/src/main/java/com/jerboa/ui/components/post/PostActivity.kt # benchmarks/src/main/java/com/jerboa/actions/JerboaActions.kt
dessalines
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.android.com/jetpack/compose/lists#content-type
Adds content types to the lazy columns. From my limited testing, I did not notice any significant performance changes.