Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backwards compatible language picker #873

Merged
merged 5 commits into from
Jun 25, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Jun 24, 2023

Adds a language picker that is backwards compatible with android 13 per app language setting.
Tested on API 26, 31, 33.

As soon as you select the new language it is saved and everything changes to that language.

Fixes #755

image

@krestenlaust
Copy link

Maybe the button should redirect to language selection screen on phones on version 13, having them use the native configuration instead.

MV-GH added 2 commits June 25, 2023 03:02
# Conflicts:
#	app/src/main/java/com/jerboa/MainActivity.kt
@MV-GH
Copy link
Collaborator Author

MV-GH commented Jun 25, 2023

studio64_eIYjArA47V.mp4

@MV-GH MV-GH requested a review from twizmwazin June 25, 2023 01:11
@twizmwazin twizmwazin enabled auto-merge (squash) June 25, 2023 02:42
@twizmwazin twizmwazin merged commit 7eb778d into LemmyNet:main Jun 25, 2023
@MV-GH MV-GH deleted the feat/lang-picker branch June 25, 2023 03:34
@krestenlaust
Copy link

Awesome work making it synchronize @MV-GH !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backwards compatible locale / language selection
3 participants