Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add totp field to login #868

Merged
merged 3 commits into from
Jun 25, 2023
Merged

Add totp field to login #868

merged 3 commits into from
Jun 25, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Jun 24, 2023

Adds the 2fa field for TOTP to the login form. Logging in without 2fa still works. Can't test if totp field actually works because I can't even get it work on lemmy-UI possible due to LemmyNet/lemmy#3316 (tried with ms authenticator)
But I am positive that it should work.

There was no autofill for TOTP so i used smsOTP should be enough.
Fixes #867

@twizmwazin twizmwazin merged commit ee1a82e into LemmyNet:main Jun 25, 2023
@KaKi87
Copy link

KaKi87 commented Jun 25, 2023

Hello,
Thanks for implementing this.
I'd be grateful if we could be notified when it gets released.
Thanks

@twizmwazin
Copy link
Contributor

You can use the "watch" feature on github to be notified about new releases on this repo, or there is a post on https://lemmy.ml/c/jerboa for new releases.

@KaKi87
Copy link

KaKi87 commented Jun 25, 2023

Yes, but that requires reading changelogs until finding this feature in one, and unsubscribing afterwards, while a notification in here (or only closing issues when PR is released like some other apps do) allows users to be notified only for what they're waiting for.

@twizmwazin
Copy link
Contributor

It'll be part of 0.0.36 when it is released

@MV-GH MV-GH deleted the feat/add-totp branch July 18, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2fa support
3 participants