Check server version against app minimum api version #737
Conversation
|
This also implements logging in with older, "unsupported" servers. I didn't fully test everything, but the basics seem to work (logging in, making posts, responding to posts, etc). |
beatgammit
force-pushed
the
feat/api-version-check
branch
from
c772f00 to
21e2d2a
Compare
This will pop up the version error dialog every time the user launches the app.
beatgammit
force-pushed
the
feat/api-version-check
branch
from
5bc5177 to
67e7eec
Compare
beatgammit
force-pushed
the
feat/api-version-check
branch
from
67e7eec to
906368d
Compare
| ) | ||
| val siteVersion = siteRes.data.version | ||
| if (compareVersions(siteVersion, MINIMUM_API_VERSION) < 0) { | ||
| Toast.makeText(ctx, "Server version too low.", Toast.LENGTH_SHORT).show() |
There was a problem hiding this comment.
Not sure how to do that since stringResource needs a Composable block. That's why I didn't use the AlertDialog here.
I can look into it again though, there ought to be a solution. I'll look around though.
There was a problem hiding this comment.
I think ctx.getString(R.string... is how you do it.
There was a problem hiding this comment.
Thanks. It's fixed now.
beatgammit
force-pushed
the
feat/api-version-check
branch
from
6845d09 to
8e0c496
Compare
|
@dessalines Is it possible to do a earlier release but not make available. So that it gets already reviewed. Atm it takes about a week to be actually available on the play store. And in that period users wont be able to use the app. |
|
I propose turning on "Managed Publishing" as mentioned here: https://support.google.com/googleplay/android-developer/answer/9859654?hl=en So submit ASAP but hold the publish for the day 0.18 goes live. Then turn it off afterward until the next big lemmy release. |
This will pop up the version error dialog every time the user launches the app.
Fixes #701 and #673.