Added unit tests for easy-to-test utils #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I got some examples on how to test the UI in my benchmarks pr, but UiAutomator2 is not 100% reliable though |
beatgammit
force-pushed
the
feat/add-unit-tests-and-coverage
branch
3 times, most recently
from
87ca05c to
39e3b46
Compare
|
Awesome, I'll check out that branch and try running your examples while I'm at it. |
|
They are not unit tests though but its the same way you can do Ui testing through UiAutomator2 |
beatgammit
force-pushed
the
feat/add-unit-tests-and-coverage
branch
from
39e3b46 to
0036bca
Compare
|
Mark this as ready to review, when its good to go. |
|
I think he is gonna add those others tests in a different pr and this is ready |
dessalines
reviewed
Jun 14, 2023
|
This also needs the gradle tests to be added to our Add a separate CI step containing |
beatgammit
force-pushed
the
feat/add-unit-tests-and-coverage
branch
3 times, most recently
from
ecf1159 to
de70cce
Compare
Also includes some small changes, fixes, and comments here and there.
Also ignore the example unit tests.
beatgammit
force-pushed
the
feat/add-unit-tests-and-coverage
branch
from
de70cce to
9243b49
Compare
|
Woodpecker config added and tests pass. I'm going to look into UI tests in a bit, but not as part of this PR. |
Closed
Chris-Kropp
pushed a commit
to Chris-Kropp/jerboa
that referenced
this pull request
Jun 16, 2023
* Added unit tests for easy-to-test utils Also includes some small changes, fixes, and comments here and there. * Enable unit tests in CI Also ignore the example unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some small changes, fixes, and comments here and there.
I still need to figure out how to write tests for the UI, but hopefully this helps a little.